-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Register Hash for glam types #6786
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
A simple quality-of-life change that makes Bevy easier to use
A-Reflection
Runtime information about types
A-Math
Fundamental domain-agnostic mathematical operations
labels
Nov 28, 2022
alice-i-cecile
approved these changes
Nov 28, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Nov 28, 2022
tim-blackbird
approved these changes
Nov 28, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 28, 2022
# Objective - fixes #6736 ## Solution - Register `Hash` on all of glam's reflected integer vector types.
bors
bot
changed the title
Register Hash for glam types
[Merged by Bors] - Register Hash for glam types
Nov 28, 2022
taiyoungjang
pushed a commit
to taiyoungjang/bevy
that referenced
this pull request
Dec 15, 2022
# Objective - fixes bevyengine#6736 ## Solution - Register `Hash` on all of glam's reflected integer vector types.
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - fixes bevyengine#6736 ## Solution - Register `Hash` on all of glam's reflected integer vector types.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - fixes bevyengine#6736 ## Solution - Register `Hash` on all of glam's reflected integer vector types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Math
Fundamental domain-agnostic mathematical operations
A-Reflection
Runtime information about types
C-Usability
A simple quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Hash
for glam types #6736Solution
Hash
on all of glam's reflected integer vector types.